linux-kernel - Re: [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in wbcir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff9593f2d918e13b39ed272e3c74cef8@hardeman.nu>
Date:   Wed, 19 Oct 2016 13:03:45 +0000
From:   "David Härdeman" <david@...deman.nu>
To:     "SF Markus Elfring" <elfring@...rs.sourceforge.net>,
        linux-media@...r.kernel.org,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Sean Young" <sean@...s.org>
Cc:     "LKML" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "Julia Lawall" <julia.lawall@...6.fr>
Subject: Re: [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in
 wbcir_tx()

October 14, 2016 1:41 PM, "SF Markus Elfring" <elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 14 Oct 2016 07:19:00 +0200
> 
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Sure...why not...

Signed-off-by: David Härdeman <david@...deman.nu>


> ---
> drivers/media/rc/winbond-cir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
> index 95ae60e..59050f5 100644
> --- a/drivers/media/rc/winbond-cir.c
> +++ b/drivers/media/rc/winbond-cir.c
> @@ -660,7 +660,7 @@ wbcir_tx(struct rc_dev *dev, unsigned *b, unsigned count)
> unsigned i;
> unsigned long flags;
> 
> - buf = kmalloc(count * sizeof(*b), GFP_KERNEL);
> + buf = kmalloc_array(count, sizeof(*b), GFP_KERNEL);
> if (!buf)
> return -ENOMEM;
> 
> -- 
> 2.10.1