linux-kernel - Re: [media] winbond-cir: Move assignments for three variables in wbcir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10715e71c46bda76f6c8654675062f61@hardeman.nu>
Date:   Wed, 19 Oct 2016 13:47:43 +0000
From:   "David Härdeman" <david@...deman.nu>
To:     "SF Markus Elfring" <elfring@...rs.sourceforge.net>,
        linux-media@...r.kernel.org
Cc:     "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Sean Young" <sean@...s.org>,
        "LKML" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "Julia Lawall" <julia.lawall@...6.fr>
Subject: Re: [media] winbond-cir: Move assignments for three variables in
 wbcir_shutdown()

October 19, 2016 3:38 PM, "SF Markus Elfring" <elfring@...rs.sourceforge.net> wrote:
>>> Move the setting for the local variables "mask", "match" and "rc6_csl"
>>> behind the source code for a condition check by this function
>>> at the beginning.
>> 
>> Again, I can't see what the point is?
> 
> * How do you think about to set these variables only after the initial
> check succeded?

I prefer setting variables early so that no thinking about whether they're initialized or not is necessary later. 

> * Do you care for data access locality?

Not unless you can show measurable performance improvements?