linux-kernel - Re: [PATCH -next] greybus: es2: fix error return code in ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOh2x=kFhCHgf8HJmuDYqxMQfEmSE03LJ1tkpVJzpH6K9arYnQ@mail.gmail.com>
Date:   Wed, 19 Oct 2016 19:37:19 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Alexandre Bailon <abailon@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        driver-dev <devel@...verdev.osuosl.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

On Wed, Oct 19, 2016 at 6:47 PM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
> APBridgeA RPC")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/staging/greybus/es2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
> index 8eabc71..a97fccf 100644
> --- a/drivers/staging/greybus/es2.c
> +++ b/drivers/staging/greybus/es2.c
> @@ -1547,7 +1547,8 @@ static int ap_probe(struct usb_interface *interface,
>         INIT_LIST_HEAD(&es2->arpcs);
>         spin_lock_init(&es2->arpc_lock);
>
> -       if (es2_arpc_in_enable(es2))
> +       retval = es2_arpc_in_enable(es2);
> +       if (retval)
>                 goto error;
>
>         retval = gb_hd_add(hd);

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>