linux-kernel - Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81c8e00d-2a78-d5ca-e75a-aeafbe3020cf@synopsys.com>
Date:   Wed, 19 Oct 2016 10:02:35 -0700
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Noam Camus <noamca@...lanox.com>
CC:     "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Noam Camus <noamc@...hip.com>
Subject: Re: [PATCH v2] ARC: Adjust cpuinfo for non-continuous cpu ids

On 10/19/2016 04:25 AM, Noam Camus wrote:
> From: Noam Camus <noamc@...hip.com>
>
> num_possible_cpus() returns how many CPUs may be present on system.
> However we want the highest possible CPU number.
> This may be differ in a sparsed possible CPUs map.
> Such map achived by OF for plat-eznps.
>
> For example if we have:
> possible cpus mask 0,3
>
> Then:
> num_possible_cpus() is equal 2
> 	while
> nr_cpu_ids is equal 4.
>
> Only for value 4 c_start() will provide correct cpuinfo at procfs.

This is much much better. Applied to for-curr !

Thx,
-Vineet

>
> Signed-off-by: Noam Camus <noamc@...hip.com>
> ---
>  arch/arc/kernel/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index 64907de..bd2e3a4 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -512,7 +512,7 @@ static void *c_start(struct seq_file *m, loff_t *pos)
>  	 * way to pass it w/o having to kmalloc/free a 2 byte string.
>  	 * Encode cpu-id as 0xFFcccc, which is decoded by show routine.
>  	 */
> -	return *pos < num_possible_cpus() ? cpu_to_ptr(*pos) : NULL;
> +	return *pos < nr_cpu_ids ? cpu_to_ptr(*pos) : NULL;
>  }
>  
>  static void *c_next(struct seq_file *m, void *v, loff_t *pos)