linux-kernel - Re: [PATCH 2/2] perf, tools, list: Support matching by topic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161019183218.GU26852@two.firstfloor.org>
Date:   Wed, 19 Oct 2016 11:32:18 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/2] perf, tools, list: Support matching by topic

> > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> > index 1095a6dada66..c00b0eb343c0 100644
> > --- a/tools/perf/builtin-list.c
> > +++ b/tools/perf/builtin-list.c
> > @@ -67,9 +67,11 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
> >  			print_symbol_events(NULL, PERF_TYPE_SOFTWARE,
> >  					event_symbols_sw, PERF_COUNT_SW_MAX, raw_dump);
> >  		else if (strcmp(argv[i], "cache") == 0 ||
> > -			 strcmp(argv[i], "hwcache") == 0)
> > +			 strcmp(argv[i], "hwcache") == 0) {
> 
> This is changing existing behaviour, please remove it. A separate patch
> could either make it show both hwcache events and vendor cache events,

That's what the patch does: "show both hwcache and vendor cache events"
which is a reasonable default.

I can split it into a separate patch if makes you feel better.

> 
> >  			print_hwcache_events(NULL, raw_dump);
> > -		else if (strcmp(argv[i], "pmu") == 0)
> > +			print_pmu_events(argv[i], raw_dump, !desc_flag,
> > +					long_desc_flag, true);
> > +		} else if (strcmp(argv[i], "pmu") == 0)
> >  			print_pmu_events(NULL, raw_dump, !desc_flag,
> >  						long_desc_flag, false);
> 
> What is this here?

Only adding a } but diff displays it in a weird way.

-Andi