linux-kernel - Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161019192801.imyce7ijsliikwk3@pd.tnic>
Date:   Wed, 19 Oct 2016 21:28:01 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Alexander Kuleshov <kuleshovmail@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/calling.h: remove unused addskip parameter of
 ALLOC_PT_GPREGS_ON_STACK

On Thu, Oct 20, 2016 at 01:11:08AM +0600, Alexander Kuleshov wrote:
> as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  arch/x86/entry/calling.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 9a9e588..b493c6a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
>  
>  #define SIZEOF_PTREGS	21*8
>  
> -	.macro ALLOC_PT_GPREGS_ON_STACK addskip=0
> -	addq	$-(15*8+\addskip), %rsp
> +	.macro ALLOC_PT_GPREGS_ON_STACK
> +	addq	$-(15*8), %rsp
>  	.endm
>  
>  	.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
> -- 

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.