linux-kernel - Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161019202643.GB78689@f23x64.localdomain>
Date:   Wed, 19 Oct 2016 13:26:43 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Azael Avalos <coproscefalo@...il.com>
Cc:     "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        carlos@...angeworlds.co.uk
Subject: Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba
 laptops

On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote:
> *ping*
> 
> 2016-08-28 11:00 GMT-06:00 Darren Hart <dvhart@...radead.org>:
> > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote:
> >> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver
> >> is not Toshiba specific, and as such, the driver was being loaded
> >> on non Toshiba laptops too.
> >>
> >> This patch adds a DMI matching list checking for TOSHIBA as the
> >> vendor, refusing to load if it is not.
> >>
> >> Also the WMI GUID was renamed, dropping the TOSHIBA_ prefix, to
> >> better reflect that such GUID is not a Toshiba specific one.
> >>
> >> Cc: <stable@...r.kernel.org> # 4.4+
> >> Signed-off-by: Azael Avalos <coproscefalo@...il.com>
> >> ---
> >> Hi Darren,
> >>
> >> I was waiting on input from the bug above, but haven't received an
> >> answer (as of yet), so I decided to send this to the mailing list
> >> for feedback as to whether this is the correct approach for this
> >> issue.
> >
> > Thanks. Let's see if Carlos (wmi.c author) has an opinion...
> >
> > Carlos?
> 
> Any input on this?

Looks like a sane workaround to me. Queued to fixes.

Want to going to stable?
-- 
Darren Hart
Intel Open Source Technology Center