linux-kernel - [PATCH 2/5] blackfin-irqchip: Combine two seq_printf() calls into one call in arch_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2f2180b-5507-92d9-49bc-74e010db6c5f@users.sourceforge.net>
Date:   Wed, 19 Oct 2016 22:47:46 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     adi-buildroot-devel@...ts.sourceforge.net,
        Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
        Steven Miao <realmz6@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 2/5] blackfin-irqchip: Combine two seq_printf() calls into one
 call in arch_show_interrupts()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 19 Oct 2016 21:19:50 +0200

Some data were printed into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 arch/blackfin/kernel/irqchip.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/kernel/irqchip.c b/arch/blackfin/kernel/irqchip.c
index 052cde5..b59ad4c 100644
--- a/arch/blackfin/kernel/irqchip.c
+++ b/arch/blackfin/kernel/irqchip.c
@@ -41,8 +41,10 @@ int arch_show_interrupts(struct seq_file *p, int prec)
 	seq_printf(p, "%*s: ", prec, "NMI");
 	for_each_online_cpu(j)
 		seq_printf(p, "%10u ", cpu_pda[j].__nmi_count);
-	seq_printf(p, "  CORE  Non Maskable Interrupt\n");
-	seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count));
+	seq_printf(p,
+		   "  CORE  Non Maskable Interrupt\n"
+		   "%*s: %10u\n",
+		   prec, "ERR", atomic_read(&irq_err_count));
 	return 0;
 }
 #endif
-- 
2.10.1