linux-kernel - Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161019205128.GE8871@codeaurora.org>
Date:   Wed, 19 Oct 2016 13:51:28 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     Michael Turquette <mturquette@...libre.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from
 pxa2xx-cpufreq

On 10/19, Robert Jarzmik wrote:
> Stephen Boyd <sboyd@...eaurora.org> writes:
> 
> > On 10/18, Robert Jarzmik wrote:
> >> Robert Jarzmik <robert.jarzmik@...e.fr> writes:
> >> Hi Michael and Stephen,
> >> 
> >> I'm planing on sending a v2 next week with minor corrections, mostly in the data
> >> tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong.
> >> 
> >> If you want me modify this serie, will you have time to review for next week or
> >> should I delay the v2 posting ?
> >> 
> >
> > No need to delay. clk patches look fine with a quick glance. It
> > would be really neat if we could make cpufreq-dt work without DT.
> > What's blocking that? OPP tables?
> 
> Heu I'm not the author of cpufreq-dt, so I'm not the best to answer.
> To answer the question "without DT", it depends if you mean "with ACPI" or "with
> platform_data" or something else.

I mean platform_data mostly. Do you use ACPI with the clk driver?

> 
> From what I've seen so far, the missing/blocking points are :
>  - the OPP points definition as you said

Hm.. I thought cpufreq-dt worked with OPP tables populated by
other code (i.e. platform code).

>  - probably same thing for the input power supply / regulator

Regulators should be optional I hope. Do you use regulators in
your design that has platform_data?

>  - the cooling parts probably
>  - and more generaly all the cpufreq-dt is built around device-tree
>  - last point, the name from KConfig, "Generic DT based cpufreq driver"
>    => that strongly suggest it's device-tree only
> 
> I'm deeply convinced that Viresh being one of the authors will shed more light
> on this.

Sure, thanks for the notes.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project