linux-kernel - Re: [PATCH 03/37] staging:r8188eu: remove skb cloning after netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2016 11:43:22 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ivan Safonov <insafonov@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Geliang Tang <geliangtang@....com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/37] staging:r8188eu: remove skb cloning after
 netdev_alloc_skb fail

On Wed, Oct 19, 2016 at 10:07:31PM +0700, Ivan Safonov wrote:
> In accordance with the KISS principle.
> 

The changelog is not complete enough.

Some people are going to read only the subject, but other people are
only going to read the body of the changelog.  They can be far apart
depending on how you look at patches.  For example:
http://marc.info/?l=linux-driver-devel&m=147688960328996&w=2

It should say: "Just drop the packet if we can't allocate data.  Don't
go to a lot of work to try recover.  Let the other side resend the
data."

regards,
dan carpenter