linux-kernel - Re: [PATCH] bnx2x: Replace semaphore stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2016 11:16:26 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Binoy Jayan <binoy.jayan@...aro.org>
Cc:     Ariel Elior <ariel.elior@...gic.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2x: Replace semaphore stats_lock with mutex

On Thursday, October 20, 2016 2:22:12 PM CEST Binoy Jayan wrote:
> @@ -1976,8 +1973,8 @@ int bnx2x_stats_safe_exec(struct bnx2x *bp,
>         /* Wait for statistics to end [while blocking further requests],
>          * then run supplied function 'safely'.
>          */
> -       rc = down_timeout(&bp->stats_lock, HZ / 10);
> -       if (unlikely(rc)) {
> +       rc = mutex_trylock(&bp->stats_lock);
> +       if (unlikely(!rc)) {
>                 BNX2X_ERR("Failed to take statistics lock for safe execution\n");
>                 goto out_no_lock;
>         }

This conversion looks suspicious, your changelog text does not mention
at all why would be to remove the timeout and fail immediately.

In fact, you don't seem to have any mutex_lock() call left, just
mutex_trylock(), and everything that tries to get the mutex fails
immediately if someone else holds it. The existing behavior of
the driver is not much better (it always gives up after 100ms),
but I think this needs some more thought put into it.

	Arnd