linux-kernel - Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161020111323.GP4329@intel.com>
Date:   Thu, 20 Oct 2016 14:13:23 +0300
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of
 GPIO controller

On Thu, Oct 20, 2016 at 12:36:13PM +0300, Andy Shevchenko wrote:
> The Crystal Cove GPIO driver has its explicit name, i.e. crystal_cove_gpio.
> 
> Use it explicitly to be in align with the rest of code, pretty grepping, and
> prevent potential breakage if GPIO driver file name ever changed.
> 
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/mfd/intel_soc_pmic_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 12d6ebb4..7fd8e87 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -34,7 +34,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
>  	.dev_id = "0000:00:02.0",
>  	.table = {
>  		/* Panel EN/DISABLE */
> -		GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> +		GPIO_LOOKUP("crystal_cove_gpio", 94, "panel", GPIO_ACTIVE_HIGH),

This looks like it would break things. The gpio_chip->label which is
used for the lookup is based on KBUILD_MODNAME and the moduled is
called gpio-crystalcove.

>  		{ },
>  	},
>  };
> -- 
> 2.9.3

-- 
Ville Syrjälä
Intel OTC