linux-kernel - Re: [PATCH] pinctrl: st: don't specify default interrupt trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <729ebc94-5476-65a7-cc17-eabfba0d2404@st.com>
Date:   Thu, 20 Oct 2016 13:35:37 +0200
From:   Patrice Chotard <patrice.chotard@...com>
To:     <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <kernel@...inux.com>, <peter.griffin@...aro.org>,
        <lee.jones@...aro.org>
Subject: Re: [PATCH] pinctrl: st: don't specify default interrupt trigger



On 10/18/2016 09:16 AM, patrice.chotard@...com wrote:
> From: Patrice Chotard <patrice.chotard@...com>
> 
> Thanks to 332e99d5ae4 which now alerts of default
> trigger usage when configuring interrupts.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@...com>
> ---
>  drivers/pinctrl/pinctrl-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 99da4cf..b7bb371 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
>  	if (info->irqmux_base || gpio_irq > 0) {
>  		err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip,
>  					   0, handle_simple_irq,
> -					   IRQ_TYPE_LEVEL_LOW);
> +					   IRQ_TYPE_NONE);
>  		if (err) {
>  			gpiochip_remove(&bank->gpio_chip);
>  			dev_info(dev, "could not add irqchip\n");
> 

Hi Linus

I forgot to mention that this patch is dedicated for v4.9-rcs 

Thanks

Patrice