linux-kernel - RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR0701MB1838DC7E1F47DA9A02230D64F0D50@SN1PR0701MB1838.namprd07.prod.outlook.com>
Date:   Thu, 20 Oct 2016 00:04:19 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Cathal Mullaney <chuckleberryfinn@...il.com>
CC:     "Sell, Timothy C" <Timothy.Sell@...sys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor
 locking code to be statically deterministic.

> -----Original Message-----
> From: Cathal Mullaney [mailto:chuckleberryfinn@...il.com]
> Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking
> code to be statically deterministic.
> 
> This patch makes locking in visorchannel_signalempty statically
> deterministic.
> As a result this patch fixes the sparse warning:
> Context imbalance in 'visorchannel_signalempty' - different lock
> contexts for basic block.
> 
> The logic of the locking code doesn't change but the layout of the
> original code is "frowned upon"
> according to mails on sparse context checking.
> Refactoring removes the warning and makes the code more readable.
> 
> Signed-off-by: Cathal Mullaney <chuckleberryfinn@...il.com>

Tested-by: David Kershner <david.kershner@...sys.com>

> ---
> V2: Removed unnecessary variable initialization, as suggested by Tim Sell
> <Timothy.Sell@...sys.com>.
> 
>  drivers/staging/unisys/visorbus/visorchannel.c | 30 ++++++++++++++++----
> ------