[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdYnbGPXO0uPrY4gaaS-PieUJej4agkixpPxW=k9qFs8ZA@mail.gmail.com>
Date: Thu, 20 Oct 2016 14:23:41 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Linux Input <linux-input@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Hans de Goede <hdegoede@...hat.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Aaron Lu <aaron.lu@...el.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] Input: gpio_keys_polled - always use gpiod_get_value_cansleep
On Thu, Oct 20, 2016 at 1:41 AM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> It does not matter if given GPIO may sleep or not when reading state,
> polling is always done in a non-atomic context, so we should always
> be able to simply use gpiod_get_value_cansleep().
>
> Also let's note in the logs when we fail to read gpio state.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
Apart from the other comments mentioned:
Acked-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
Powered by blists - more mailing lists