linux-kernel - RE: [PATCH] ACPICA: arm64: fix compile apci tools fail for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1AE640813FDE7649BE1B193DEA596E886A256324@SHSMSX101.ccr.corp.intel.com>
Date:   Thu, 20 Oct 2016 18:42:00 +0000
From:   "Zheng, Lv" <lv.zheng@...el.com>
To:     Yisheng Xie <xieyisheng1@...wei.com>,
        "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "wmiles@....com" <wmiles@....com>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "guohanjun@...wei.com" <guohanjun@...wei.com>,
        "wangxiongfeng2@...wei.com" <wangxiongfeng2@...wei.com>
Subject: RE: [PATCH] ACPICA: arm64: fix compile apci tools fail for arm64

Hi,

> From: linux-acpi-owner@...r.kernel.org [mailto:linux-acpi-owner@...r.kernel.org] On Behalf Of Yisheng
> Xie
> Subject: Re: [PATCH] ACPICA: arm64: fix compile apci tools fail for arm64
> 
> Hi,
> 
> On 2016/10/19 6:07, Zheng, Lv wrote:
> > Hi,
> >
> > I'm not sure what you mean.
> > I mean you need ACPI_USE_SYSTEM_INTTYPES in case s64 has already been defined in that environment.
> > Are you sure s64 should be defined for your environment?
> >
> s64 is not defined in my build environment but in kernel code.

Yes, in-kernel ACPICA applications trickily reused this to get it compiled in kernel source tree with minimal porting effort.
And it is working on x86.

> 
> > IMO, s64 is kernel space specific, while you are compiling user space tools.
> > It looks to me like there is something wrong with ARM kernel's asm/types.h.
> >
> >> I listed in change log. And I also have tried that way.
> >> However, it still have many other errors.(I am sorry to not have listed all of them.)
> >>
> >> From the following log, you can see, all of the conflict type is from signal.h.
> >> And maybe this patch is a better way to fix these compile error, without too much
> >> change of code.
> >>
> >> Are you sure that it will cause order problem when build ACPICA on other build
> >> environment, for it only effect aarch64.
> >
> > I'm not sure what this is.
> > How did you get this?
> > Were you compiling kernel acpi tools or compiling the kernel itself?
> >
> It's about compiling kernel acpi tools.
> 
> > For tool compilation, are you sure you have correctly configured your cross-compilation environment?
> Maybe it is not my cross-compilation environment problem, for your also can reproduce it,
> as your said in another email, right?

Yes, I reproduced it.
By commenting out <signal.h> inclusion from acenv.h.
Tools can be built by aarch64-linux-gnu tool chain downloaded from linaro.

However this is still not the root cause, IMO.

Thanks
Lv

> 
> > Will you see problems in compiling ACPICA applications from:
> > https://github.com/acpica/acpica
> >
> 
> > Thanks
> > Lv
> >
> > .
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html