linux-kernel - Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be72dfec-b502-1888-4495-9a476f91d6b6@codeaurora.org>
Date:   Thu, 20 Oct 2016 14:59:49 -0700
From:   Sarangdhar Joshi <spjoshi@...eaurora.org>
To:     Andy Gross <andy.gross@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>,
        Trilok Soni <tsoni@...eaurora.org>
Subject: Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes

On 10/20/2016 02:51 PM, Andy Gross wrote:
> On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
>> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
>>> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>>>
>>>> From: Bjorn Andersson <bjorn.andersson@...aro.org>
>>>>
>>>> Add SMEM and TCSR DT nodes on MSM8996.
>>>>
>>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>>>> Signed-off-by: Sarangdhar Joshi <spjoshi@...eaurora.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
>>>> 1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> index 949b096..0a810f5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> @@ -169,12 +169,31 @@
>>>> 		method = "smc";
>>>> 	};
>>>>
>>>> +	smem {
>>>> +		compatible = "qcom,smem";
>>>> +
>>>> +		memory-region = <&smem_mem>;
>>>> +
>>>> +		hwlocks = <&tcsr_mutex 3>;
>>>> +	};
>>>> +
>>>> 	soc: soc {
>>>> 		#address-cells = <1>;
>>>> 		#size-cells = <1>;
>>>> 		ranges = <0 0 0 0xffffffff>;
>>>> 		compatible = "simple-bus";
>>>>
>>>> +		tcsr_mutex_regs: syscon@...000 {
>>>> +			compatible = "syscon";
>>>> +			reg = <0x740000 0x20000>;
>>>> +		};
>>>> +
>>>> +		tcsr_mutex: hwlock {
>>>> +			compatible = "qcom,tcsr-mutex";
>>>> +			syscon = <&tcsr_mutex_regs 0 0x1000>;
>>>> +			#hwlock-cells = <1>;
>>>> +		};
>>>
>>> Sorry, I got this in the wrong place, the hwlock node should sit outside
>>> of soc {} - looks like we got this wrong in msm8916 as well.
>>
>> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
>> root)?
>
> Yes.  Any node that doesn't have reg properties should go under the root.
>

Got it. Will update the patch(es) and add cover letter. Thanks.

>
> Andy
>

Regards,
Sarang
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project