linux-kernel - Re: [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbZfLMGndsMvueXA6jvsX62tyKjikz1FzpKW+yL=weoXA@mail.gmail.com>
Date:   Fri, 21 Oct 2016 00:08:01 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Neil Armstrong <narmstrong@...libre.com>,
        Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     Peter Rosin <peda@...ntia.se>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Wei Chen <Wei.Chen@....com>, Roland Stigge <stigge@...com.de>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Subject: Re: [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

On Tue, Sep 27, 2016 at 5:48 PM, Neil Armstrong <narmstrong@...libre.com> wrote:

> Since the I2C sx150x GPIO expander driver uses platform_data to manage
> the pins configurations, rewrite the driver as a pinctrl driver using
> pinconf to get/set pin configurations from DT or debugfs.
>
> The pinctrl driver is functionnally equivalent as the gpio-only driver
> and can use DT for pinconf. The platform_data confirmation is dropped.
>
> This patchset removed the gpio-only driver and selects the Pinctrl driver
> config instead. This patchset also migrates the gpio dt-bindings to pinctrl
> and add the pinctrl optional properties.
>
> The driver was tested with a SX1509 device on a BeagleBone black with
> interrupt support and on an X86_64 machine over an I2C to USB converter.
>
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>

I think we're ready to apply this to the GPIO and pinctrl trees.
Could you:

- Rebase on top of v4.9-rc1 (fails to apply for me)
- Add the collected ACKs
- See if Andrey can provide an additional Test tag
- Resend

Also please look at Andreys patches to see if there is some good
inspiration for further cleanups.

Yours,
Linus Walleij