linux-kernel - Re: [PATCH v6] powerpc: Do not make the entire heap executable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161020224521.GA24970@obsidianresearch.com>
Date:   Thu, 20 Oct 2016 16:45:21 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Florian Weimer <fweimer@...hat.com>,
        Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable

On Tue, Oct 04, 2016 at 09:54:12AM -0700, Kees Cook wrote:
> On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman <mpe@...erman.id.au> wrote:
> > Kees Cook <keescook@...omium.org> writes:
> >
> >> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@...hat.com> wrote:
> >>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt,
> >>> or with a toolchain which defaults to it) look like this:
> > ...
> >>>
> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> >>> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> >>> Acked-by: Kees Cook <keescook@...omium.org>
> >>> Acked-by: Michael Ellerman <mpe@...erman.id.au>
> >>> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> >>> CC: Paul Mackerras <paulus@...ba.org>
> >>> CC: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
> >>> CC: Kees Cook <keescook@...omium.org>
> >>> CC: Oleg Nesterov <oleg@...hat.com>
> >>> CC: Michael Ellerman <mpe@...erman.id.au>
> >>> CC: Florian Weimer <fweimer@...hat.com>
> >>> CC: linux-mm@...ck.org
> >>> CC: linuxppc-dev@...ts.ozlabs.org
> >>> CC: linux-kernel@...r.kernel.org
> >>> Changes since v5:
> >>> * made do_brk_flags() error out if any bits other than VM_EXEC are set.
> >>>   (Kees Cook: "With this, I'd be happy to Ack.")
> >>>   See https://patchwork.ozlabs.org/patch/661595/
> >>
> >> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree?
> >
> > -mm would be best, given the diffstat I think it's less likely to
> >  conflict if it goes via -mm.
> 
> Okay, excellent. Andrew, do you have this already in email? I think
> you weren't on the explicit CC from the v6...

FWIW (and ping),

Tested-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

On ARM32 (kirkwood) and PPC32 (405)

For reference, here is the patchwork URL:

https://patchwork.ozlabs.org/patch/677753/

Jason