[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1610211710440.16183@macbook-air>
Date: Fri, 21 Oct 2016 17:16:22 -0400 (EDT)
From: Vince Weaver <vincent.weaver@...ne.edu>
To: Wang Nan <wangnan0@...wei.com>
cc: mtk.manpages@...il.com, pi3orama@....com,
linux-kernel@...r.kernel.org, linux-man@...r.kernel.org,
lizefan@...wei.com, vincent.weaver@...ne.edu
Subject: Re: [PATCH 1/2] perf_event_open.2: Document
PERF_EVENT_IOC_PAUSE_OUTPUT
On Fri, 21 Oct 2016, Wang Nan wrote:
> -.SS Using prctl(2)
> +.SS Using prctl
why this change?
> +.BR PERF_EVENT_IOC_PAUSE_OUTPUT " (since Linux 4.7)"
> +.\" commit 86e7972f690c1017fd086cdfe53d8524e68c661c
> +This allows pausing and resuming the event's ring-buffer. A
> +paused ring-buffer does not prevent samples generation, but simply
> +discards them. The discarded samples are considered lost, causes
> +.BR PERF_RECORD_LOST
> +to be generated when possible.
I don't know if it's worth mentioning that the reason to add this is to
allow reading the ring-buffer without having to worry about data being
overwritten.
There are a few odd wording choices (mostly plural nouns) but otherwise
looks fine to me.
Reviewed-by: Vince Weaver <vincent.weaver@...ne.edu>
Powered by blists - more mailing lists