linux-kernel - Re: [PATCH] pinctrl: qcom: Add msm8994 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161021230757.GA8076@mini-rhel.redhat.com>
Date:   Fri, 21 Oct 2016 16:07:58 -0700
From:   Jeremy McNicoll <jmcnicol@...hat.com>
To:     Michael Scott <michael.scott@...aro.org>
Cc:     linux-gpio@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Joonwoo Park <joonwoop@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        Jeremy McNicoll <jeremymc@...hat.com>
Subject: Re: [PATCH] pinctrl: qcom: Add msm8994 pinctrl driver

On Fri, Oct 21, 2016 at 03:42:50PM -0700, Michael Scott wrote:
> Initial pinctrl driver for QCOM msm8994 platforms.
> 
> In order to continue the initial board support for QCOM msm8994/msm8992
> presented in patches from Jeremy McNicoll <jeremymc@...hat.com>, let's put
> a proper pinctrl driver in place.
> 
> Currently, the DT for these platforms uses the msm8x74 pinctrl driver to enable
> basic UART.  Beyond the first few pins the rest are different enough to justify
> it's own driver.
> 
> Note: This driver is also be used by QCOM's msm8992 platform as it's TLM block
> is the same.
> 
> - Initial formatting and style was taken from the msm8x74 pinctrl driver added
>   by Björn Andersson <bjorn.andersson@...aro.org>
> - Data was then adjusted per QCOM MSM8994 documentation for Top Level Multiplexing
> - Bindings documentation was based on qcom,msm8996-pinctrl.txt by
>   Joonwoo Park <joonwoop@...eaurora.org> and then modified for msm8994 content
> 
> Signed-off-by: Michael Scott <michael.scott@...aro.org>
> ---
>  .../bindings/pinctrl/qcom,msm8994-pinctrl.txt      |  175 +++
>  drivers/pinctrl/qcom/Kconfig                       |    9 +
>  drivers/pinctrl/qcom/Makefile                      |    1 +
>  drivers/pinctrl/qcom/pinctrl-msm8994.c             | 1402 ++++++++++++++++++++
>  4 files changed, 1587 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8994-pinctrl.txt
>  create mode 100644 drivers/pinctrl/qcom/pinctrl-msm8994.c
>

This works fine on my msm8992 which currently only supports basic
serial.

Having already compared it to downstream it looks like things
line up pretty good. (from a msm8992 perspective)

Reviewed-by: Jeremy McNicoll <jeremymc@...hat.com>


-jeremy