linux-kernel - Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1610210918420.3212@hadrien>
Date:   Fri, 21 Oct 2016 09:20:03 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
cc:     linux-hexagon@...r.kernel.org, Richard Kuo <rkuo@...eaurora.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one
 call in show_cpuinfo()



On Fri, 21 Oct 2016, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 21 Oct 2016 08:18:38 +0200
>
> Some data were printed into a sequence by four separate function calls.
> Print the same data by a single function call instead.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  arch/hexagon/kernel/setup.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/arch/hexagon/kernel/setup.c b/arch/hexagon/kernel/setup.c
> index 6981949..ff37044 100644
> --- a/arch/hexagon/kernel/setup.c
> +++ b/arch/hexagon/kernel/setup.c
> @@ -132,13 +132,14 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>  	if (!cpu_online(cpu))
>  		return 0;
>  #endif
> -
> -	seq_printf(m, "processor\t: %d\n", cpu);
> -	seq_printf(m, "model name\t: Hexagon Virtual Machine\n");
> -	seq_printf(m, "BogoMips\t: %lu.%02lu\n",
> -		(loops_per_jiffy * HZ) / 500000,
> -		((loops_per_jiffy * HZ) / 5000) % 100);
> -	seq_printf(m, "\n");
> +	seq_printf(m,
> +		   "processor\t: %d\n"
> +		   "model name\t: Hexagon Virtual Machine\n"
> +		   "BogoMips\t: %lu.%02lu\n"
> +		   "\n",
> +		   cpu,
> +		   (loops_per_jiffy * HZ) / 500000,
> +		   ((loops_per_jiffy * HZ) / 5000) % 100);

This looks completely pointless. It is harder to see how the arguments fit
into the strings and it is harder to see where the strings end and the
arguments begin.

julia


>  	return 0;
>  }
>
> --
> 2.10.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>