linux-kernel - Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <488cd9f4-1522-6346-6618-0f3168badf96@intel.com>
Date:   Fri, 21 Oct 2016 10:23:29 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Javier Martinez Canillas <javier@....samsung.com>,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload

On 21/10/16 09:48, Ludovic Desroches wrote:
> On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
>> alias:          of:N*T*Catmel,sama5d2-sdhciC*
>> alias:          of:N*T*Catmel,sama5d2-sdhci
>>
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@...el.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> 
> Thanks
>> ---
>>
>>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
>> index a9b7fc06c434..2f9ad213377a 100644
>> --- a/drivers/mmc/host/sdhci-of-at91.c
>> +++ b/drivers/mmc/host/sdhci-of-at91.c
>> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>>  	{ .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>>  	{}
>>  };
>> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>>  
>>  #ifdef CONFIG_PM
>>  static int sdhci_at91_runtime_suspend(struct device *dev)
>> -- 
>> 2.7.4
>>
>