linux-kernel - Re: [PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Oct 2016 10:49:44 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Frank Rowand <frowand.list@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Debjit Ghosh <dghosh@...iper.net>,
        Georgi Vlaev <gvlaev@...iper.net>,
        Guenter Roeck <linux@...ck-us.net>,
        JawaharBalaji Thirumalaisamy <jawaharb@...iper.net>,
        Mohammad Kamil <mkamil@...iper.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver

On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou
<pantelis.antoniou@...sulko.com> wrote:

> From: Georgi Vlaev <gvlaev@...iper.net>
>
> This driver exports the CB FPGA presence detect bits from a
> single 32bit CB register as GPIOs.
>
> Signed-off-by: Georgi Vlaev <gvlaev@...iper.net>
> Signed-off-by: Guenter Roeck <groeck@...iper.net>
> [Ported from Juniper kernel]
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@...sulko.com>

This needs some more verbose commit message and explanation.

Note: GPIO = General Purpose Input/Output.

This doesn't really sound like general purpose, more like special
purpose.

Consider drivers/input and drivers/connector classes for example.

> +config GPIO_CBC_PRESENCE
> +       tristate "Juniper Networks PTX1K CBC presence detect as GPIO"
> +       depends on MFD_JUNIPER_CBC && OF
> +       default y if JNX_CONNECTOR
> +       help
> +         This driver exports the CH_PRS and OTHER_CH_PRS presence detect
> +         bits of the PTX1K RCB CBC FPGA as GPIOs on the relevant Juniper
> +         platforms. Select if JNX_CONNECTOR is selected.
> +
> +         This driver can also be built as a module.  If so, the module
> +         will be called gpio-cbc-presence.

At least tell us *what* it is detecting the presence of.

Apart from this it has some of the same issues pointed out in the
other drivers, correct these as well.

Yours,
Linus Walleij