linux-kernel - Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <747ba5dc-8015-7634-eb1c-94f82ebb75b1@linux.intel.com>
Date:   Fri, 21 Oct 2016 08:23:41 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Andi Kleen <ak@...ux.intel.com>, Nilay Vaish <nilayvaish@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Linux Kernel list <Linux-kernel@...r.kernel.org>,
        kan.liang@...el.com
Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch
 counting in callchain

Hi Andi, Hi Nilay,

Thanks so much for your comments!

I will upgrade the patch to just display the count for abort.

Thanks

Jin Yao

On 10/21/2016 2:20 AM, Andi Kleen wrote:
>> OK, I am more confused now.  Are you predicting some quantity related
>> to transactions?  Why would you divide abort count by branch count?
>> Further, I just looked at patch 6/6.  It has the following text:
>>
>> + Also show with some branch flags that can be:
>> + - Predicted: display the average percentage of predicated branches.
>> +     (predicated number / total number)
>> + - Abort: display the average percentage of abort branches.
>> + (abort number /total number)
>> + - Cycles: cycles in basic block.
>>
>>
>> I think there is inconsistency between what you are suggesting and
>> what the patch has.
> An abort is an unique branch. But yes there is no total number,
> so the formula will always be 100%. So yes would probably be
> better to just display a count for abort.
>
> -Andi