lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Oct 2016 14:47:22 +0200 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Daniel Lezcano <daniel.lezcano@...aro.org> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org> Subject: Re: [PATCH 2/2] cpuidle: governors: Move the files to the upper directory On Wed, Oct 5, 2016 at 9:33 AM, Daniel Lezcano <daniel.lezcano@...aro.org> wrote: > Currently the different governors are stored in the subdir > 'governors'. That is not a problem. > > However, that forces to declare some private structure in the > include/linux/cpuidle.h header because these governor files > don't have access to the private 'cpuidle.h' located in > drivers/cpuidle. > > Instead of having the governors in the separate directory, move > them along with the drivers and prefix them with 'governor-', > that allows to do a proper cleanup in the cpuidle headers. While I'm not particularly against this change, I'm sort of wondering about the reason. What in particular would be wrong with doing #include "../cpuidle.h" in a governor .c file? Thanks, Rafael
Powered by blists - more mailing lists