linux-kernel - Re: [PATCH v5 2/4] drm/fence: release fence reference when canceling event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Oct 2016 14:52:37 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Gustavo Padovan <gustavo@...ovan.org>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Daniel Stone <daniels@...labora.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Rob Clark <robdclark@...il.com>,
        Greg Hackmann <ghackmann@...gle.com>,
        John Harrison <John.C.Harrison@...el.com>,
        laurent.pinchart@...asonboard.com, seanpaul@...gle.com,
        marcheu@...gle.com, m.chehab@...sung.com,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Gustavo Padovan <gustavo.padovan@...labora.co.uk>
Subject: Re: [PATCH v5 2/4] drm/fence: release fence reference when canceling
 event

On Thu, Oct 20, 2016 at 12:50:03PM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> 
> If the event gets canceled we also need to put away the fence
> reference it holds.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

I've broken my local dim scripts right now, so can't apply ;-)
-Daniel

> ---
>  drivers/gpu/drm/drm_fops.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c
> index e84faec..8bed5f4 100644
> --- a/drivers/gpu/drm/drm_fops.c
> +++ b/drivers/gpu/drm/drm_fops.c
> @@ -663,6 +663,10 @@ void drm_event_cancel_free(struct drm_device *dev,
>  		list_del(&p->pending_link);
>  	}
>  	spin_unlock_irqrestore(&dev->event_lock, flags);
> +
> +	if (p->fence)
> +		fence_put(p->fence);
> +
>  	kfree(p);
>  }
>  EXPORT_SYMBOL(drm_event_cancel_free);
> -- 
> 2.5.5
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch