linux-kernel - Re: [PATCH] block: Change extern inline to static inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161021142900.GY24289@lahna.fi.intel.com>
Date:   Fri, 21 Oct 2016 17:29:00 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...com>
Subject: Re: [PATCH] block: Change extern inline to static inline

On Fri, Oct 21, 2016 at 04:19:26PM +0200, Tobias Klauser wrote:
> With compilers which follow the C99 standard (like modern versions of
> gcc and clang), "extern inline" does the opposite thing from older
> versions of gcc (emits code for an externally linkable version of the
> inline function).
> 
> "static inline" does the intended behavior in all cases instead.
> 
> Description taken from commit 6d91857d4826 ("staging, rtl8192e,
> LLVMLinux: Change extern inline to static inline").
> 
> This also fixes the following GCC warning when building with !PM:
> ./include/linux/blkdev.h:1143:20: warning: no previous prototype for 'blk_set_runtime_active' [-Wmissing-prototypes]
> 
> Fixes: d07ab6d11477 ("block: Add blk_set_runtime_active()")
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>

Hehe, indeed that "extern" was probably copy pasted from the non-inline
declaration.

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>