linux-kernel - Re: 4.9 regression/bisection - 761ed4a94582 tty: serial_core: convert uart_close to use tty_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477060817.8523.33.camel@gmail.com>
Date:   Fri, 21 Oct 2016 16:40:17 +0200
From:   Mike Galbraith <umgwanakikbuti@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Hurley <peter@...leysoftware.com>
Subject: Re: 4.9 regression/bisection - 761ed4a94582 tty: serial_core:
 convert uart_close to use tty_port_close

On Fri, 2016-10-21 at 08:51 -0500, Rob Herring wrote:
> On Fri, Oct 21, 2016 at 7:45 AM, Mike Galbraith
> <umgwanakikbuti@...il.com> wrote:
> > Greetings,
> > 
> > My old DL980 G7 is exploding on reboot with master, with only the first
> > couple lines actually making it to the console.  Once (and only once)
> > during bisection it did manage to get the below emitted.
> 
> Does this patch[1] fix things for you? Sorry, only the reply seems to
> be in the archives.

Nope, still went boom.

---
 drivers/tty/serial/serial_core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2746,8 +2746,6 @@ int uart_add_one_port(struct uart_driver
 	uport->cons = drv->cons;
 	uport->minor = drv->tty_driver->minor_start + uport->line;
 
-	port->console = uart_console(uport);
-
 	/*
 	 * If this port is a console, then the spinlock is already
 	 * initialised.
@@ -2761,6 +2759,8 @@ int uart_add_one_port(struct uart_driver
 
 	uart_configure_port(drv, state, uport);
 
+	port->console = uart_console(uport);
+
 	num_groups = 2;
 	if (uport->attr_group)
 		num_groups++;