linux-kernel - Re: [PATCH] acpi/apei: Fix in-correct return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877f9121h4.fsf@e105922-lin.cambridge.arm.com>
Date:   Fri, 21 Oct 2016 15:58:15 +0100
From:   Punit Agrawal <punit.agrawal@....com>
To:     "Baicar\, Tyler" <tbaicar@...eaurora.org>
Cc:     linux-acpi@...r.kernel.org, rjw@...ysocki.net,
        linux-kernel@...r.kernel.org, bp@...e.de,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] acpi/apei: Fix in-correct return value

"Baicar, Tyler" <tbaicar@...eaurora.org> writes:

> On 10/18/2016 10:07 AM, Punit Agrawal wrote:
>> Although ghes_proc tests for error while reading the error status, it
>> always return success (0). Fix this by propagating the return value.
>>
>> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support")
>> Signed-of-by: Punit Agrawal <punit.agrawa.@....com>
>> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
>> Cc: Len Brown <lenb@...nel.org>
> Tested-by: Tyler Baicar <tbaicar@...eaurora.org>

Thanks for taking the patch for a spin.

Hopefully Rafael can pick the patch as a fixes for the next rc.


>
> Thanks,
> Tyler
>> ---
>>   drivers/acpi/apei/ghes.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
>> index f0a029e..0d099a2 100644
>> --- a/drivers/acpi/apei/ghes.c
>> +++ b/drivers/acpi/apei/ghes.c
>> @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)
>>   	ghes_do_proc(ghes, ghes->estatus);
>>   out:
>>   	ghes_clear_estatus(ghes);
>> -	return 0;
>> +	return rc;
>>   }
>>     static void ghes_add_timer(struct ghes *ghes)