linux-kernel - Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161021154624.maiwbgjmzlzhin2l@thunk.org>
Date:   Fri, 21 Oct 2016 11:46:24 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Julia Lawall <julia.lawall@...6.fr>, linux-hexagon@...r.kernel.org,
        Richard Kuo <rkuo@...eaurora.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one
 call in show_cpuinfo()

On Fri, Oct 21, 2016 at 11:00:22AM +0200, SF Markus Elfring wrote:
> 
> > It is harder to see how the arguments fit into the strings
> > and it is harder to see where the strings end and the arguments begin.
> 
> Is it really so difficult to interpret the suggested construction
> of a single (and relatively small) format string?

It's not so difficult, so much as it makes things worse.  It's easier
the way it originally was.  It might be interesting to see if the
compiler could be taught to collapse the function calls, but (a) this
isn't performance critical, and (b) the number of bytes saved is
really tiny.  But at least if the compiler was doing the work, it
would at least deal with it everywhere.

					- Ted