linux-kernel - Re: [PATCH] perf c2c report: Properly check data presence in rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Oct 2016 14:23:49 -0500
From:   Kim Phillips <kim.phillips@....com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, <linux-kernel@...r.kernel.org>,
        Linux Weekly News <lwn@....net>,
        Andi Kleen <andi@...stfloor.org>,
        David Ahern <dsahern@...il.com>,
        Don Zickus <dzickus@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
        Joe Mario <jmario@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        "Arnaldo Carvalho de Melo" <acme@...hat.com>
Subject: Re: [PATCH] perf c2c report: Properly check data presence in
 rb_tree loop

On Fri, 21 Oct 2016 02:17:06 +0200
Jiri Olsa <jolsa@...hat.com> wrote:

> On Thu, Oct 20, 2016 at 06:02:24PM -0500, Kim Phillips wrote:
> 
> SNIP
> 
> > (gdb) bt
> > #0  c2c_browser__update_nr_entries (hb=<optimized out>, hb=<optimized out>) at builtin-c2c.c:2142
> > #1  perf_c2c__hists_browse (hists=0x8b2d90 <c2c+240>) at builtin-c2c.c:2287
> > #2  perf_c2c_display (session=0x205b1a0) at builtin-c2c.c:2316
> > #3  perf_c2c__report (argv=<optimized out>, argc=<optimized out>) at builtin-c2c.c:2621
> > #4  cmd_c2c (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin-c2c.c:2748
> > #5  0x000000000048df61 in run_builtin (p=p@...ry=0x8be168 <commands+72>, argc=argc@...ry=2, argv=argv@...ry=0x7fffffffddb0)
> >     at perf.c:358
> > #6  0x00000000004249b6 in handle_internal_command (argv=0x7fffffffddb0, argc=2) at perf.c:420
> > #7  run_argv (argv=0x7fffffffdb40, argcp=0x7fffffffdb4c) at perf.c:466
> > #8  main (argc=2, argv=0x7fffffffddb0) at perf.c:610
> > (gdb) 
> > 
> > All the above work fine when run under sudo.
> 
> ugh, stupid mistake.. attached patch fixes that for me

I see it's been merged here now:

https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/c2c&id=5a1a99cd2e4e15571a74f65facf05f806d5303fd

and the updated perf-c2c-for-mingo-20161021 works, so thanks all.

Kim