linux-kernel - Re: [PATCH 1/2] fscrypto: Fix log string in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161021200200.GA137744@google.com>
Date:   Fri, 21 Oct 2016 13:02:00 -0700
From:   Eric Biggers <ebiggers@...gle.com>
To:     Richard Weinberger <richard@....at>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        jaegeuk@...nel.org, tytso@....edu
Subject: Re: [PATCH 1/2] fscrypto: Fix log string in do_crypto()

On Tue, Oct 18, 2016 at 10:54:48PM +0200, Richard Weinberger wrote:
> The operations supports both encryption and decryption.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  fs/crypto/crypto.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c
> index 61057b7dbddb..1637a0450b9f 100644
> --- a/fs/crypto/crypto.c
> +++ b/fs/crypto/crypto.c
> @@ -194,8 +194,9 @@ static int do_page_crypto(struct inode *inode,
>  	skcipher_request_free(req);
>  	if (res) {
>  		printk_ratelimited(KERN_ERR
> -			"%s: crypto_skcipher_encrypt() returned %d\n",
> -			__func__, res);
> +			"%s: crypto_skcipher_%scrypt() returned %d, flags %#x\n",
> +			__func__, rw == FS_DECRYPT ? "de" : "en", res,
> +			crypto_skcipher_get_flags(tfm));
>  		return res;
>  	}
>  	return 0;
> -- 
> 2.7.3
> 

Looks fine.

Reviewed-by: Eric Biggers <ebiggers@...gle.com>