linux-kernel - [RFC] put more pressure on proc/sysfs slab shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <bca13f1ae6a72f0d126cd7e9ede11baaa2b81064.1477081587.git.shli@fb.com>
Date:   Fri, 21 Oct 2016 13:35:14 -0700
From:   Shaohua Li <shli@...com>
To:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <Kernel-team@...com>, <viro@...iv.linux.org.uk>
Subject: [RFC] put more pressure on proc/sysfs slab shrink

In our systems, proc/sysfs inode/dentry cache use more than 1G memory
even memory pressure is high sometimes. Since proc/sysfs is in-memory
filesystem, rebuilding the cache is fast. There is no point proc/sysfs
and disk fs have equal pressure for slab shrink.

One idea is directly discarding proc/sysfs inode/dentry cache rightly
after the proc/sysfs file is closed. But the discarding will make
proc/sysfs file open slower next time, which is 20x slower in my test if
multiple applications are accessing proc files. This patch doesn't go
that far. Instead, just put more pressure to shrink proc/sysfs slabs.

Signed-off-by: Shaohua Li <shli@...com>
---
 fs/kernfs/mount.c | 2 ++
 fs/proc/inode.c   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c
index d5b149a..5b4e747 100644
--- a/fs/kernfs/mount.c
+++ b/fs/kernfs/mount.c
@@ -161,6 +161,8 @@ static int kernfs_fill_super(struct super_block *sb, unsigned long magic)
 	sb->s_xattr = kernfs_xattr_handlers;
 	sb->s_time_gran = 1;

+	sb->s_shrink.seeks = 1;
+	sb->s_shrink.batch = 0;
 	/* get root inode, initialize and unlock it */
 	mutex_lock(&kernfs_mutex);
 	inode = kernfs_get_inode(sb, info->root->kn);
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index e69ebe6..afef9fb 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -474,6 +474,8 @@ int proc_fill_super(struct super_block *s, void *data, int silent)
 	s->s_op = &proc_sops;
 	s->s_time_gran = 1;

+	s->s_shrink.seeks = 1;
+	s->s_shrink.batch = 0;
 	/*
 	 * procfs isn't actually a stacking filesystem; however, there is
 	 * too much magic going on inside it to permit stacking things on
-- 
2.9.3