linux-kernel - Re: [PATCH 1/3] drm/amdgpu: change function declarations and add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f6d7e72a-c2cb-668f-4ef9-c3241823692f@folklore1984.net>
Date:   Sat, 22 Oct 2016 20:30:20 +1100
From:   Edward O'Callaghan <funfunctor@...klore1984.net>
To:     Baoyou Xie <baoyou.xie@...aro.org>, alexander.deucher@....com,
        christian.koenig@....com, airlied@...ux.ie,
        nicolai.haehnle@....com, Jammy.Zhou@....com, Qingqing.Wang@....com,
        daniel.vetter@...ll.ch, tom.stdenis@....com,
        michel.daenzer@....com, gustavo.padovan@...labora.co.uk,
        eric.engestrom@...tec.com, Emily.Deng@....com, David1.Zhou@....com,
        CARLOS.PALMINHA@...opsys.com, ville.syrjala@...ux.intel.com,
        Flora.Cui@....com, vitaly.prosyak@....com,
        alexandre.f.demers@...il.com, Jerry.Zhang@....com, Rex.Zhu@....com
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, xie.baoyou@....com.cn, han.fei@....com.cn,
        tang.qiang007@....com.cn
Subject: Re: [PATCH 1/3] drm/amdgpu: change function declarations and add
 missing header dependencies

This series is,
Acked-by: Edward O'Callaghan <funfunctor@...klore1984.net>

On 10/22/2016 07:48 PM, Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c:38:6: warning: no previous prototype for 'amdgpu_atombios_crtc_overscan_setup' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:661:6: warning: no previous prototype for 'dce_v8_0_disable_dce' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:40:5: warning: no previous prototype for 'amdgpu_gfx_scratch_get' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:62:6: warning: no previous prototype for 'amdgpu_gfx_scratch_free' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are declared in
> drivers/gpu/drm/amd/amdgpu/atombios_crtc.h
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.h
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.h
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.h
> drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h.
> So this patch adds missing header dependencies.
> 
> By the way, this patch changes declaration of amdgpu_gfx_parse_disable_cu()
> to subject to its implement, and clean three function declarations
> in pp_acpi.h up.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c       | 1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h       | 3 ++-
>  drivers/gpu/drm/amd/amdgpu/atombios_crtc.c    | 1 +
>  drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        | 1 +
>  drivers/gpu/drm/amd/amdgpu/dce_v11_0.c        | 1 +
>  drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         | 1 +
>  drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c | 1 +
>  drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h   | 9 +++------
>  8 files changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index a074edd..01a42b6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -24,6 +24,7 @@
>   */
>  #include <drm/drmP.h>
>  #include "amdgpu.h"
> +#include "amdgpu_gfx.h"
>  
>  /*
>   * GPU scratch registers helpers function.
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> index 51321e1..abd9432 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> @@ -27,6 +27,7 @@
>  int amdgpu_gfx_scratch_get(struct amdgpu_device *adev, uint32_t *reg);
>  void amdgpu_gfx_scratch_free(struct amdgpu_device *adev, uint32_t reg);
>  
> -unsigned amdgpu_gfx_parse_disable_cu(unsigned *mask, unsigned max_se, unsigned max_sh);
> +void amdgpu_gfx_parse_disable_cu(unsigned int *mask, unsigned int max_se,
> +		unsigned int max_sh);
>  
>  #endif
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
> index f7d236f..8c9bc75 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c
> @@ -31,6 +31,7 @@
>  #include "atom.h"
>  #include "atom-bits.h"
>  #include "atombios_encoders.h"
> +#include "atombios_crtc.h"
>  #include "amdgpu_atombios.h"
>  #include "amdgpu_pll.h"
>  #include "amdgpu_connectors.h"
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
> index 4108c68..443b35f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
> @@ -31,6 +31,7 @@
>  #include "atombios_encoders.h"
>  #include "amdgpu_pll.h"
>  #include "amdgpu_connectors.h"
> +#include "dce_v10_0.h"
>  
>  #include "dce/dce_10_0_d.h"
>  #include "dce/dce_10_0_sh_mask.h"
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> index f264b8f..d58638c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> @@ -31,6 +31,7 @@
>  #include "atombios_encoders.h"
>  #include "amdgpu_pll.h"
>  #include "amdgpu_connectors.h"
> +#include "dce_v11_0.h"
>  
>  #include "dce/dce_11_0_d.h"
>  #include "dce/dce_11_0_sh_mask.h"
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> index 5966166..dd5838c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> @@ -31,6 +31,7 @@
>  #include "atombios_encoders.h"
>  #include "amdgpu_pll.h"
>  #include "amdgpu_connectors.h"
> +#include "dce_v8_0.h"
>  
>  #include "dce/dce_8_0_d.h"
>  #include "dce/dce_8_0_sh_mask.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
> index 1944d28..f5e8fda 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
> @@ -25,6 +25,7 @@
>  #include "linux/delay.h"
>  #include "hwmgr.h"
>  #include "amd_acpi.h"
> +#include "pp_acpi.h"
>  
>  bool acpi_atcs_functions_supported(void *device, uint32_t index)
>  {
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h b/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h
> index 3df5de2..8fe8ba9 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h
> @@ -21,9 +21,6 @@
>   *
>   */
>  
> -extern bool acpi_atcs_functions_supported(void *device,
> -							uint32_t index);
> -extern int acpi_pcie_perf_request(void *device,
> -						uint8_t perf_req,
> -						bool advertise);
> -extern bool acpi_atcs_notify_pcie_device_ready(void *device);
> +bool acpi_atcs_functions_supported(void *device, uint32_t index);
> +int acpi_pcie_perf_request(void *device, uint8_t perf_req, bool advertise);
> +bool acpi_atcs_notify_pcie_device_ready(void *device);
> 



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)