lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Oct 2016 19:32:47 +0200 From: Karol Herbst <karolherbst@...il.com> To: Baoyou Xie <baoyou.xie@...aro.org> Cc: Ben Skeggs <bskeggs@...hat.com>, David Airlie <airlied@...ux.ie>, Alexandre Courbot <acourbot@...dia.com>, Ilia Mirkin <imirkin@...m.mit.edu>, Julia.Lawall@...6.fr, Martin Peres <martin.peres@...e.fr>, rspliet@...ipso.eu, Karol Herbst <nouveau@...olherbst.de>, arnd@...db.de, ML nouveau <nouveau@...ts.freedesktop.org>, tang.qiang007@....com.cn, xie.baoyou@....com.cn, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, dri-devel@...ts.freedesktop.org, han.fei@....com.cn Subject: Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies I think it would be better to squash those commits: 1. for the includes 2. for static declerations 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@...aro.org>: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] > > In fact, these functions are declared in > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h. > So this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org> > --- > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > index 34ecd4a..058ff46 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > @@ -20,6 +20,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > #include <core/device.h> > +#include <core/firmware.h> > > /** > * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory > -- > 2.7.4 > > _______________________________________________ > Nouveau mailing list > Nouveau@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau
Powered by blists - more mailing lists