linux-kernel - [PATCH] iio: dac: mcp4725: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1610222238240.2191@hadrien>
Date:   Sat, 22 Oct 2016 22:41:32 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Tomas Novotny <tomas@...otny.cz>
cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Yong Li <sdliyong@...il.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...org
Subject: [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Tomas Novotny <tomas@...otny.cz>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

Not checked at all.  This is being reported on the following tree:

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
testing
head:   2796a310d462f73954c0ce8ffabaf4baacaecca1
commit: e0b80def1faa901d83a7d580e8aa4ad4a512bedf [109/113] iio: dac:
mcp4725: support voltage reference selection
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago


 mcp4725.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -418,7 +418,7 @@ static int mcp4725_probe(struct i2c_clie
 	if (pdata->use_vref) {
 		data->vref_reg = devm_regulator_get(&client->dev, "vref");
 		if (IS_ERR(data->vref_reg)) {
-			err = PTR_ERR(data->vdd_reg);
+			err = PTR_ERR(data->vref_reg);
 			goto err_disable_vdd_reg;
 		}