linux-kernel - Re: [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into one call in sn2_ptc_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72f6fc41-9bf8-2eef-848f-8eefba7dade6@users.sourceforge.net>
Date:   Sat, 22 Oct 2016 22:48:07 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Joe Perches <joe@...ches.com>, linux-ia64@...r.kernel.org
Cc:     Al Viro <viro@...iv.linux.org.uk>, Borislav Petkov <bp@...e.de>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>,
        Ingo Molnar <mingo@...nel.org>,
        Jörg Rödel <jroedel@...e.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Robert Richter <rrichter@...ium.com>,
        Robin Murphy <robin.murphy@....com>,
        Tony Luck <tony.luck@...el.com>,
        Toshi Kani <toshi.kani@....com>,
        Vineet Gupta <vgupta@...opsys.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into one
 call in sn2_ptc_seq_show()

>> @@ -494,12 +494,11 @@ static int sn2_ptc_seq_show(struct seq_file *file, void *data)
>>  	int cpu;
>>  
>>  	cpu = *(loff_t *) data;
>> -
>> -	if (!cpu) {
>> +	if (!cpu)
>>  		seq_printf(file,
>> -			   "# cpu ptc_l newrid ptc_flushes nodes_flushed deadlocks lock_nsec shub_nsec shub_nsec_max not_my_mm deadlock2 ipi_fluches ipi_nsec\n");
>> -		seq_printf(file, "# ptctest %d, flushopt %d\n", sn2_ptctest, sn2_flush_opt);
>> -	}
>> +			   "# cpu ptc_l newrid ptc_flushes nodes_flushed deadlocks lock_nsec shub_nsec shub_nsec_max not_my_mm deadlock2 ipi_fluches ipi_nsec\n"
>> +			   "# ptctest %d, flushopt %d\n",
>> +			   sn2_ptctest, sn2_flush_opt);
>>  
>>  	if (cpu < nr_cpu_ids && cpu_online(cpu)) {
>>  		stat = &per_cpu(ptcstats, cpu);
> 
> Please think more.
> 
> printf has to inspect character by character looking for
> a vsprintf % character and 0 termination.
> 
> seq_puts does a strlen then memcpy.

Would you prefer to use this function also at this source code place?

Regards,
Markus