linux-kernel - Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161022081448.GB32560@spreadtrum.com>
Date:   Sat, 22 Oct 2016 16:14:49 +0800
From:   Xiaolong Zhang <xiaolong.zhang@...eadtrum.com>
To:     Stephen Boyd <sboyd@...eaurora.org>
CC:     <mturquette@...libre.com>, <orson.zhai@...eadtrum.com>,
        <baolin.wang@...eadtrum.com>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <ben.li@...eadturm.com>
Subject: Re: [PATCH] clk: Register clkdev after setup of fixed-rate and
 fixed-factor clocks

On 四, 10月 20, 2016 at 04:01:03下午 -0700, Stephen Boyd wrote:
> On 10/11, Orson Zhai wrote:
> > From: Xiaolong Zhang <xiaolong.zhang@...eadtrum.com>
> > 
> > When common kernel setups fixed clock, of_clk_provider will be registerred.
> > But there is no clkdev being registerred at the same time. This will make
> > it difficult to get the clock by using clk_get(NULL, con_id).
> > 
> > Add clkdev register for fixed-rate and fixed-factor clock and ignore
> > the error if any.
> > 
> > Signed-off-by: Xiaolong Zhang <xiaolong.zhang@...eadtrum.com>
> > Signed-off-by: Orson Zhai <orson.zhai@...eadtrum.com>
> > ---
> 
> Why are we using clkdev lookups for clks populated from DT?
> Shouldn't we be able to point to them from the consumers that
> would also be in DT? I'm a little lost.
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
The clk_get interface allows the first argument as NULL. We just assure
consumers can get the clock from DT or by clock name.