linux-kernel - Re: [PATCH] x86/entry64: remove unused audit related macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161023075528.qrebhx5lmqrulz6t@pd.tnic>
Date:   Sun, 23 Oct 2016 09:55:29 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Alexander Kuleshov <kuleshovmail@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/entry64: remove unused audit related macros

On Sun, Oct 23, 2016 at 12:10:32AM +0600, Alexander Kuleshov wrote:
> which are ocured in the 86a1c34a929f commit (x86_64 syscall audit
> fast-path by Roland McGrath <roland@...hat.com>) and now they are
> not used anymore.

I'd prefer it if you said which patch *removed* them and made those
defines unused again.

What would be even better is if your commit message explained *why* they
were removed in that patch and that because of <insert reason here> we
don't need them here anymore.

This should give people looking at your patch the warm and fuzzy feeling
they need in order to apply it. :-)

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.