linux-kernel - Re: [patch v3] drivers/platform/x86: introduce support for Mellanox hotplug driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161023082353.GA1714@nanopsycho.orion>
Date:   Sun, 23 Oct 2016 10:23:53 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [patch v3] drivers/platform/x86: introduce support for Mellanox
 hotplug driver

Sun, Oct 23, 2016 at 08:14:53AM CEST, vadimp@...lanox.com wrote:
>
>
>> -----Original Message-----
>> From: Darren Hart [mailto:dvhart@...radead.org]
>> Sent: Friday, October 21, 2016 9:42 PM
>> To: Vadim Pasternak <vadimp@...lanox.com>
>> Cc: davem@...emloft.net; geert@...ux-m68k.org; akpm@...ux-
>> foundation.org; kvalo@...eaurora.org; gregkh@...uxfoundation.org;
>> mchehab@...nel.org; linux@...ck-us.net; linux-kernel@...r.kernel.org;
>> platform-driver-x86@...r.kernel.org; jiri@...nulli.us
>> Subject: Re: [patch v3] drivers/platform/x86: introduce support for Mellanox
>> hotplug driver
>> 
>> On Thu, Oct 20, 2016 at 04:28:01PM +0000, vadimp@...lanox.com wrote:
>> > From: Vadim Pasternak <vadimp@...lanox.com>
>> >
>> > Enable system support for the Mellanox Technologies hotplug platform
>> > driver, which provides support for the next Mellanox basic systems:
>> > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
>> > "msb7800", "msn2740", "msn2100" and also various number of derivative
>> > systems from the above basic types.
>> > This driver handles hot-plug events for the power suppliers, power
>> > cables and fans for the above systems.
>> >
>> > The Kconfig currently controlling compilation of this code is:
>> > driver/platform/x86:config MLX_CPLD_PLATFORM
>> >                        tristate "Mellanox platform hotplug driver support"
>> >
>> > Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
>> > ---
>> > v1->v2:
>> >  Comments pointed out by Darren:
>> >  - remove whitespaces in config;
>> >  - remove redundant includes for header files;
>> >  - fix comments styling;
>> >  - fix register value assignment in mlxcpld_hotplug_attr_show;
>> >  - mlxcpld_hotplug_attr_init - use local aliases to reduce line
>> > length;
>> >  - Add fields description in the struct mlxcpld_hotplug_device;
>> > v2->v3:
>> >  Comments pointed out by Darren:
>> >   - Fix structures and enum comments in mlxcpld-hotplug.c according to
>> >     Documentation/kernel-documentation.rst guideline;
>> >   - Assign and mask aggregation status in mlxcpld_hotplug_work_handler on
>> >     the same line.
>> >   - Refactor mlxcpld_hotplug_work_handler. Make common helper routine for
>> >     each attribute type.
>> >   - Produce error message in case signal is not expected.
>> >   - Fix header file according to Documentation/kernel-documentation.rst
>> >     guideline;
>> 
>> >  Fix added by Vadim:
>> > 	Fix re-scheduling flow for possibly missed signals. By mistake it
>> > 	was coupled with FAN.
>> 
>> Thanks Vadim. Merged to for-next for 4.10.
>> 
>> Also for 4.10, it would be good to move mlx-platform out of arch/x86/platform
>> to
>> drivers/platform/x86 as it isn't an architectural driver. Would you be able to
>> prepare the patch?
>
>Hi Darren,
>
>Thank you very much for all your reviews.
>
>Sure, I'll prepare the patch.
>
>Should it be submitted in two different patches (remove in git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git; and add in
>git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git)?
>Or in one patch, in  git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git?

One patch, please.


>
>Thanks,
>Vadim.
>
>> 
>> Thanks,
>> 
>> --
>> Darren Hart
>> Intel Open Source Technology Center