linux-kernel - Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3zilu4a4q.fsf@t19.piap.pl>
Date:   Mon, 24 Oct 2016 06:57:25 +0200
From:   khalasa@...p.pl (Krzysztof Hałasa)
To:     Andrey Utkin <andrey.utkin@...p.bluecherry.net>
Cc:     mchehab@...nel.org, stable@...r.kernel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        maintainers@...echerrydvr.com, andrey_utkin@...tmail.com,
        ismael@...ev.co.uk, hverkuil@...all.nl, hans.verkuil@...co.com
Subject: Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

Andrey Utkin <andrey.utkin@...p.bluecherry.net> writes:

> --- a/drivers/media/pci/solo6x10/solo6x10.h
> +++ b/drivers/media/pci/solo6x10/solo6x10.h
> @@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev *solo_dev, int reg)
>  static inline void solo_reg_write(struct solo_dev *solo_dev, int reg,
>  				  u32 data)
>  {
> +	u16 val;
> +
>  	writel(data, solo_dev->reg_base + reg);
> +	pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val);
>  }
>  
>  static inline void solo_irq_on(struct solo_dev *dev, u32 mask)

This is ok for now. I hope I will find some to refine this, so not all
register writes are done with the penalty - eventually.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland