linux-kernel - Re: [PATCH] Input: psmouse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161024233550.GA9026@dtor-ws>
Date:   Mon, 24 Oct 2016 16:35:50 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Dmitry Tunin <hanipouspilot@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mathias Gottschlag <mgottschlag@...il.com>
Subject: Re: [PATCH] Input: psmouse - cleanup Focaltech code

On Sat, Oct 08, 2016 at 01:38:56PM +0300, Dmitry Tunin wrote:
> psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as
> "FocaltechPS/2 Focaltech Focaltech Touchpad"
> 
> In focaltech_report_state() pointer to psmouse->dev is already stored as *dev
> 
> Signed-off-by: Dmitry Tunin <hanipouspilot@...il.com>

Applied, thank you.

> ---
>  drivers/input/mouse/focaltech.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c
> index c8c6a8c..49a56f655 100644
> --- a/drivers/input/mouse/focaltech.c
> +++ b/drivers/input/mouse/focaltech.c
> @@ -43,7 +43,7 @@ int focaltech_detect(struct psmouse *psmouse, bool set_properties)
>  
>  	if (set_properties) {
>  		psmouse->vendor = "FocalTech";
> -		psmouse->name = "FocalTech Touchpad";
> +		psmouse->name = "Touchpad";
>  	}
>  
>  	return 0;
> @@ -146,8 +146,8 @@ static void focaltech_report_state(struct psmouse *psmouse)
>  	}
>  	input_mt_report_pointer_emulation(dev, true);
>  
> -	input_report_key(psmouse->dev, BTN_LEFT, state->pressed);
> -	input_sync(psmouse->dev);
> +	input_report_key(dev, BTN_LEFT, state->pressed);
> +	input_sync(dev);
>  }
>  
>  static void focaltech_process_touch_packet(struct psmouse *psmouse,
> -- 
> 2.7.4
> 

-- 
Dmitry