linux-kernel - Re: [PATCH 26/28] nios2: fix timer initcall return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFiDJ583L2f4UhCCJ4CNf2DQ3B13H70Ru303=noMf1CkYjFsqQ@mail.gmail.com>
Date:   Mon, 24 Oct 2016 08:54:52 +0800
From:   Ley Foon Tan <lftan@...era.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>
Subject: Re: [PATCH 26/28] nios2: fix timer initcall return value

On Tue, Oct 18, 2016 at 6:16 AM, Arnd Bergmann <arnd@...db.de> wrote:
> When called more than twice, the nios2_time_init() function
> return an uninitialized value, as detected by gcc -Wmaybe-uninitialized
>
> arch/nios2/kernel/time.c: warning: 'ret' may be used uninitialized in this function
>
> This makes it return '0' here, matching the comment above the
> function.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/nios2/kernel/time.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c
> index d9563dd..746bf5c 100644
> --- a/arch/nios2/kernel/time.c
> +++ b/arch/nios2/kernel/time.c
> @@ -324,6 +324,7 @@ static int __init nios2_time_init(struct device_node *timer)
>                 ret = nios2_clocksource_init(timer);
>                 break;
>         default:
> +               ret = 0;
>                 break;
>         }
Acked-by: Ley Foon Tan <lftan@...era.com>