[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AM5PR0501MB2097118EF42DCCDC0AB83387A2A90@AM5PR0501MB2097.eurprd05.prod.outlook.com>
Date: Mon, 24 Oct 2016 06:01:36 +0000
From: Vadim Pasternak <vadimp@...lanox.com>
To: Randy Dunlap <rdunlap@...radead.org>,
"dvhart@...radead.org" <dvhart@...radead.org>,
"fengguang.wu@...el.com" <fengguang.wu@...el.com>
CC: "davem@...emloft.net" <davem@...emloft.net>,
"geert@...ux-m68k.org" <geert@...ux-m68k.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"kvalo@...eaurora.org" <kvalo@...eaurora.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"mchehab@...nel.org" <mchehab@...nel.org>,
"linux@...ck-us.net" <linux@...ck-us.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"platform-driver-x86@...r.kernel.org"
<platform-driver-x86@...r.kernel.org>,
"jiri@...nulli.us" <jiri@...nulli.us>,
"andriy.shevchenko@...ux.intel.com"
<andriy.shevchenko@...ux.intel.com>
Subject: RE: [patch v1] drivers/platform/x86: select hwmon for Mellanox
hotplug driver in Kconfig
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@...radead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@...lanox.com>; dvhart@...radead.org;
> fengguang.wu@...el.com
> Cc: davem@...emloft.net; geert@...ux-m68k.org; akpm@...ux-
> foundation.org; kvalo@...eaurora.org; gregkh@...uxfoundation.org;
> mchehab@...nel.org; linux@...ck-us.net; linux-kernel@...r.kernel.org;
> platform-driver-x86@...r.kernel.org; jiri@...nulli.us;
> andriy.shevchenko@...ux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
>
> On 10/23/16 05:45, vadimp@...lanox.com wrote:
> > From: Vadim Pasternak <vadimp@...lanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> > tristate "Mellanox platform hotplug driver support"
> > default n
> > depends on MLX_PLATFORM
> > + select HWMON
> > select I2C
> > ---help---
> > This driver handles hot-plug events for the power suppliers, power
> >
>
> Hi,
> did you test this? I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.
I re-tested it again.
I don't see any warning from kconfig. It just set " CONFIG_HWMON=m" with no warnings.
Could I miss something?
Thanks,
Vadim.
>
> thanks.
> --
> ~Randy
Powered by blists - more mailing lists