linux-kernel - Re: [PATCH v2 1/9] mtd: spi-nor: improve macronix_quad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2016 13:05:20 +0530
From:   Jagan Teki <jagan@...nedev.com>
To:     Cyrille Pitchen <cyrille.pitchen@...el.com>
Cc:     Brian Norris <computersforpeace@...il.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        nicolas.ferre@...el.com, boris.brezillon@...e-electrons.com,
        Marek Vasut <marex@...x.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/9] mtd: spi-nor: improve macronix_quad_enable()

On Wed, Oct 5, 2016 at 5:30 PM, Cyrille Pitchen
<cyrille.pitchen@...el.com> wrote:
> The patch checks whether the Quad Enable bit is already set in the Status
> Register. If so, the function exits immediately with a successful return
> code. Otherwise, a message is now printed telling we're setting the
> non-volatile bit.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>

Reviewed-by: Jagan Teki <jagan@...nedev.com>

> ---
>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d0fc165d7d66..5c87b2d99507 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1211,6 +1211,11 @@ static int macronix_quad_enable(struct spi_nor *nor)
>         val = read_sr(nor);
>         if (val < 0)
>                 return val;
> +       if (val & SR_QUAD_EN_MX)
> +               return 0;
> +
> +       /* Update the Quad Enable bit. */
> +       dev_info(nor->dev, "setting Macronix Quad Enable (non-volatile) bit\n");
>         write_enable(nor);
>
>         write_sr(nor, val | SR_QUAD_EN_MX);

Safe to save ret and check the same as well.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.