linux-kernel - Re: [PATCH] [media] st-hva: fix a copy-and-paste variable name error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb8f2ff1-68af-9a04-6e6d-3a4a585b39c1@st.com>
Date:   Mon, 24 Oct 2016 09:55:14 +0200
From:   Jean Christophe TROTIN <jean-christophe.trotin@...com>
To:     Colin King <colin.king@...onical.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [media] st-hva: fix a copy-and-paste variable name error

Thanks (and sorry for the delay of my answer),

Acked-by: Jean-Christophe Trotin <jean-christophe.trotin@...com>

On 09/19/2016 08:19 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The second check for an error on hva->lmi_err_reg appears
> to be a copy-and-paste error, it should be hva->emi_err_reg
> instead.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/media/platform/sti/hva/hva-hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
> index d341d49..dcf362c 100644
> --- a/drivers/media/platform/sti/hva/hva-hw.c
> +++ b/drivers/media/platform/sti/hva/hva-hw.c
> @@ -245,7 +245,7 @@ static irqreturn_t hva_hw_err_irq_thread(int irq, void *arg)
>  		ctx->hw_err = true;
>  	}
>
> -	if (hva->lmi_err_reg) {
> +	if (hva->emi_err_reg) {
>  		dev_err(dev, "%s     external memory interface error: 0x%08x\n",
>  			ctx->name, hva->emi_err_reg);
>  		ctx->hw_err = true;
>