linux-kernel - Re: [RFC][PATCH] Add EXPORT_MACRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161024122545.55539e53@roar.ozlabs.ibm.com>
Date:   Mon, 24 Oct 2016 12:25:45 +1100
From:   Nicholas Piggin <npiggin@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...IV.linux.org.uk>,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Gabriel C <nix.or.die@...il.com>
Subject: Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm

On Sat, 22 Oct 2016 15:08:52 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Sat, 22 Oct 2016 10:44:41 +1100
> Nicholas Piggin <npiggin@...il.com> wrote:
> 
> > >  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
> > > diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
> > > index 43199a049da5..cb86e746865e 100644
> > > --- a/include/asm-generic/export.h
> > > +++ b/include/asm-generic/export.h
> > > @@ -90,5 +90,10 @@
> > >  	__EXPORT_SYMBOL(name, KSYM(name),)
> > >  #define EXPORT_DATA_SYMBOL_GPL(name)				\
> > >  	__EXPORT_SYMBOL(name, KSYM(name),_gpl)
> > > +/*
> > > + * If "name" is a macro of a function and not a function itself,
> > > + * it needs a second pass.
> > > + */
> > > +#define EXPORT_MACRO_SYMBOL(x) EXPORT_SYMBOL(x)    
> > 
> > Seems okay, but what about just calling it EXPORT_SYMBOL?  
> 
> 
> Actually, this doesn't work. There's some magic going on it
> Makefile.build in the scripts directory that causes this to fail.
> 
> I have another patch I'll be sending on Monday that fixes this.

Yes it's grepping for EXPORT_SYMBOL_* I think. If you need to
create a new name, EXPORT_SYMBOL prefix would be preferred. But
yeah if you make the standard macro do macro expansion, it
should just work, no?