linux-kernel - Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161024093530.GV4469@mwanda>
Date:   Mon, 24 Oct 2016 12:35:31 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Brian Masney <masneyb@...tation.org>, devel@...verdev.osuosl.org,
        lars@...afoo.de, linux-iio@...r.kernel.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        pmeerw@...erw.net, knaack.h@....de
Subject: Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store()
 functions

On Sat, Oct 22, 2016 at 06:29:55PM +0100, Jonathan Cameron wrote:
> On 19/10/16 12:37, Dan Carpenter wrote:
> > I appologize for laughing, but I am still secretly amused in my heart.
> > 
> > regards,
> > dan carpenter
> > 
> Fewer beers or less caffeine for Dan!

;)

> 
> Key take away here is keep things simple.  The gotos in my mind
> would actually have made sense, but I wouldn't do the refactoring until
> you need it. i.e. when you introduce the locking in this patch.

Yeah, I totally agree do it when you need it.  I like gotos if they're
needed.

regards,
dan carpenter