lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Oct 2016 13:54:03 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: mzoran@...wfest.net Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, daniels@...labora.com, linux-kernel@...r.kernel.org, eric@...olt.net, noralf@...nnes.org, popcornmix@...il.com Subject: Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzoran@...wfest.net wrote: > From: Michael Zoran <mzoran@...wfest.net> > > Signed-off-by: Michael Zoran <mzoran@...wfest.net> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c > index 32d12e6..98c6819 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c > @@ -219,7 +219,7 @@ remote_event_signal(REMOTE_EVENT_T *event) > int > vchiq_copy_from_user(void *dst, const void *src, int size) > { > - if ((uint32_t)src < TASK_SIZE) { > + if ((unsigned long)src < TASK_SIZE) { > return copy_from_user(dst, src, size); > } else { > memcpy(dst, src, size); This code looks totally wrong still. That's not how we differentiate kernel pointers from user pointers. Also no commit message (I tend not to read the subject) so it took me a while to figure out what was going on. Anyway, everything needs a commit message. That's a rule. regards, dan carpenter
Powered by blists - more mailing lists